-
Notifications
You must be signed in to change notification settings - Fork 290
Cluster bug #10506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Cluster bug #10506
Conversation
This PR is ready for review. However, I need to conduct a broader investigation into the stability of the ruptures generated with a seed and their variability when the seed is altered. An additional possible test is the extent to which hazard curves from event-based analysis match those produced using the classical approach. |
I guess this will affect the USA model, the New Madrid cluster. Do you have an idea of how much? Should we backport the fix to the LTS version? Also, you forgot to edit the changelog. |
self._num_ruptures = len(self.data) | ||
return self._num_ruptures | ||
|
||
@num_ruptures.setter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand this. Setting num_ruptures
is potentially dangerous as it could break the relation with len(self.data)
. Why do we need this?
This PR fixes the generation of SES with a cluster model and clarifies the parameters required in the various cases supported.